-
Notifications
You must be signed in to change notification settings - Fork 35
Playwright command #1334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Playwright command #1334
Conversation
Eco CI Output [RUN-ID: 17671748212]: 🌳 CO2 Data: Total cost of whole PR so far:
|
I like the Two questions... Playwright API variantThe interface currently only supports the asynchronous API of Playwright, due to : await eval(`(async () => { ${data} })()`); Is it sufficient to only support the asynchronous API of Playwright? If so, you might implement a check if the playwright command is missing the Notes collectionHow to use btw: The synchronous function |
Regarding the Playwright API variant: The node.js implementation of Playwright only supports the asynchronous variant (the Python implementation supports both). So the question is not relevant anymore. But probably it needs to be documented, that the Node.js implementation is used under the hood and |
Good input!
|
This PR introduces the concept of having playwright commands directly in the usage scenario.
This was made based on an idea of @davidkopp
To make the commands work we need IPC between playwright and GMT.
To make this low overhead we use native I/O blocking from the linux subsystem by creating two files:
The functionality is kept hidden from the user only exposing a simple string based YML syntax.
Example can be seen here:
https://github.com/green-coding-solutions/branch-magazine-energy-tests/blob/2741f206385a5280bb275da1b5bf2db46f148185/usage_scenario_normal.yml#L66
@davidkopp How do you like this interface?