-
Notifications
You must be signed in to change notification settings - Fork 37
Saves the existing config files on install #1311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Eco CI Output - Old Energy EstimationEco CI Output [RUN-ID: 17405005416]: 🌳 CO2 Data: Total cost of whole PR so far:
|
Eco CI Output - Old Energy EstimationEco CI Output [RUN-ID: 17405053110]: 🌳 CO2 Data: Total cost of whole PR so far:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do that always manually, but do agree that this is insider knowledge and nice to have as QoL.
To my understandig these files also need to be in .gitignore:
-
docker/nginx/block.conf
- docker/nginx/frontend.conf
Can you confirm and if so add. Then please merge from your side
After thinking about this I decided to add |
Please explicitely name the files. Makes it also clearer where they are created. Catch-Alls should at least be directory restricted IMHO unless they are a standard (like .DS_Store etc.) |
Eco CI Output - Old Energy EstimationEco CI Output [RUN-ID: 17425884754]: 🌳 CO2 Data: Total cost of whole PR so far:
|
@ribalba ping |
done |
Eco CI Output [RUN-ID: 17763595356]: 🌳 CO2 Data: Total cost of whole PR so far:
|
Something that annoyed me all the time is that when I do
install_linux.sh
the install script just overwrites my config files. Especially if I have set up something not trivial and then I switch branches and install to get the right libs everything is gone. Now I just save the config files to a.backup
so I can copy paste the things I need.