-
Notifications
You must be signed in to change notification settings - Fork 37
Fixes sudo bug when creating test env #1310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hmm, not directly a fan of this edit. The problem is that the location when the first sudo hits is arbitrary. We can easily layer another instance before that and it will fail. How about making a dummy sudo call as REALLY the first step of the script. Something like "sudo echo 'ok'". ? |
Did a more robust version now. Also fixed a few things that stopped testing on Fedora |
Eco CI Output - Old Energy EstimationEco CI Output [RUN-ID: 17403646223]: 🌳 CO2 Data: Total cost of whole PR so far:
|
Eco CI Output - Old Energy EstimationEco CI Output [RUN-ID: 17403680993]: 🌳 CO2 Data: Total cost of whole PR so far:
|
Eco CI Output - Old Energy EstimationEco CI Output [RUN-ID: 17403700046]: 🌳 CO2 Data: Total cost of whole PR so far:
|
Eco CI Output [RUN-ID: 17403736538]: 🌳 CO2 Data: Total cost of whole PR so far:
|
Looks cleaner now. For my understanding: This error techically also happens when you install GMT, not? If so: I think it makes sense to also bring this code to the install_shared.sh ... what do you think? |
@ribalba Ping |
No, because the install is a shell script which understands the CTRL-C. But when calling a shell script from python the python process gets the signal. |
* main: (66 commits) Remove network from sci (#1352) Updated Cloud Energy Relaxed test due to noise of host OS network management. See #1322 for details tcpdump will report errors for now instead of except Remaned wait_time to proper name idle_time Bump psutil from 7.0.0 to 7.1.0 (#1349) Refactor logs structure to json (#1341) Removed proxy passing into docker gunicorn container Changed jobs endpoint to deliver http 202 (fix): After moving to /lib folder the __main__ check was not relevant anymore. Checking for tty now which should not conflict when running in cluster mode fixes the problem with updates not being installed (#1346) Bump fastapi[standard] from 0.116.1 to 0.116.2 (#1342) Saves the existing config files on install (#1311) Fixes sudo bug when creating test env (#1310) Bump pydantic from 2.11.7 to 2.11.9 (#1340) Bump pytest-randomly from 4.0.0 to 4.0.1 (#1339) Bump actions/github-script from 7.0.1 to 8.0.0 in /.github/workflows (#1338) Bump actions/create-github-app-token in /.github/workflows (#1337) Added powermetrics carbon entries for config.js Added more key metrics to frontend display tests ...
* main: (84 commits) Allow to stream stdout connected output (#1353) Catching exception in tcpdump Showing test duration Remove network from sci (#1352) Updated Cloud Energy Relaxed test due to noise of host OS network management. See #1322 for details tcpdump will report errors for now instead of except Remaned wait_time to proper name idle_time Bump psutil from 7.0.0 to 7.1.0 (#1349) Refactor logs structure to json (#1341) Removed proxy passing into docker gunicorn container Changed jobs endpoint to deliver http 202 (fix): After moving to /lib folder the __main__ check was not relevant anymore. Checking for tty now which should not conflict when running in cluster mode fixes the problem with updates not being installed (#1346) Bump fastapi[standard] from 0.116.1 to 0.116.2 (#1342) Saves the existing config files on install (#1311) Fixes sudo bug when creating test env (#1310) Bump pydantic from 2.11.7 to 2.11.9 (#1340) Bump pytest-randomly from 4.0.0 to 4.0.1 (#1339) Bump actions/github-script from 7.0.1 to 8.0.0 in /.github/workflows (#1338) ...
When I run the setup env python file and don't have access to my fingerprint reader I can't press CTRL-C to drop to the password entry prompt as the python process gets the interrupt. So I catch it and fail nicely.