fix a bug of getLargestTimeWindow() and add a function of failing to take different time windows of different vehicle types into account. #516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix a bug of getLargestTimeWindow()
|
hope to hear from you soon |
fail to take different time windows of different vehicle types into account.
|
fail to take different time windows of different vehicle types into account. |
jackzhenguo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix a bug of getLargestTimeWindow()
About method of getLargestTimeWindow() , it always returns a maximize time window, and it should be a bug. I have fixed it by adding a null check of timewindow variable.