Introduce ModelData class #4940
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to modelData class. animation tests are failing need to figure out why. My guess is maybe the way we read animations on the test needs to be updated.
ModelData class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
The goal of this PR is to split ModelScene into ModelData and SceneData class.
First sub task is to introduce ModelData class, ModelScene class will have a memeber of this type. I gradually start adding model related members of ModelScene to ModelData class. Making sure the functionalities still work and maybe add unit tests for it.
Eventually once we introduce extra-model element, ModelScene will have an array of ModelData per each extra model