Add exempt as bypass mode to ruleset bypass actors #3719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmlewis
suggested changes
Sep 18, 2025
There was a problem hiding this comment.
Thank you, @claystation!
One minor tweak, please, otherwise LGTM.
Note that I still don't have write access to this repo, but figure I might as well attempt to catch up on my code reviews (which I usually allow the linter to process first... ah, well).
| @@ -59,6 +59,7 @@ type BypassMode string | |||
| const ( | |||
| BypassModeAlways BypassMode = "always" | |||
| BypassModePullRequest BypassMode = "pull_request" | |||
| BypassModeExempt BypassMode = "exempt" | |||
There was a problem hiding this comment.
Would you mind sorting these 4 lines please?
I'm not sure why they weren't originally sorted.
Thank you!
There was a problem hiding this comment.
Hey!
I pushed and update, let me know what you think!
|
@gmlewis no rush. Hope you get access back soon enough! |
gmlewis
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3714