Skip to content

Conversation

thowell
Copy link
Collaborator

@thowell thowell commented Aug 12, 2025

No description provided.

@@ -29,20 +29,20 @@


def broadphase_caller(m, d):
if m.opt.broadphase == int(BroadphaseType.NXN):
if m.opt.broadphase == BroadphaseType.NXN:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this work in warp-lang 1.8.1?

Copy link
Collaborator

@btaba btaba Aug 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed offline, ideally we can wait until 1.9.0 until using this un-released feature. Or we need to migrate MJX, and all downstream packages to uv (including this one) so they can more easily depend on pre-release warp-lang

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@btaba, so what's the consensus then? Honestly, it's a superficial change, so we should just hold off or revert if it make life easier for you.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to make life easier for our users (not me necessarily :P ) since there is now a transitive dep between warp-lang and mjx externally. I don't have immediate bandwidth to migrate MJX from pip -> uv, so let's please hold off until 1.9.0 (2 weeks), or "uv", whichever comes first

@erikfrey
Copy link
Collaborator

Added #624 to track this dependency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants