Skip to content

Conversation

nsrawat0333
Copy link

Problem

Issue #609 identified that residual connections in MeshGraphNet were applied in incorrect order, potentially affecting model performance.

Solution

  • Fixed the order in _build method of meshgraphnets/core_model.py
  • Now applies edge residual connections before node processing as per paper specification
  • Ensures proper information flow: edge updates use original node features, then node updates use updated edge features

Technical Details

  • Changed from: node residuals → edge residuals
  • Changed to: edge residuals → node residuals (correct order)
  • Matches mathematical formulation in MeshGraphNet paper

Fixes #609

- Update aiohttp to address potential security vulnerabilities
- Maintains compatibility with existing codebase
- Addresses dependency security recommendations
- Add comprehensive open-source-resources.md with organized dataset links
- Update README.md with dedicated datasets section for better navigation
- Include external repository links and clear access instructions
- Improve reproducibility and research collaboration

Fixes google-deepmind#608
- Apply edge residual connections before node processing per paper
- Node updates now use updated edge features instead of update deltas
- Ensures proper information flow: e'_ij = e_ij + MLP(e_ij, v_i, v_j)
- Then: v'_i = v_i + MLP(v_i, sum(e'_ij)) using updated edges
- Matches mathematical formulation in MeshGraphNets paper

Fixes google-deepmind#609
@polarbe
Copy link

polarbe commented Aug 10, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MeshGraphNet: Residual Connection Mismatch - Node Update Uses Pre-Residual Edge Features Instead of Updated Ones
2 participants