Added custom inline nodes support #412
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeeSee
force-pushed
the
custom_inline_nodes
branch
from
fd257ca to
ca329b6
Compare
DeeSee
force-pushed
the
custom_inline_nodes
branch
from
ca329b6 to
3ee2189
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @gonzalezreal
Please look at the core idea of these changes (skipping tech details like changes in Package.swift). I'd love to know if you think these worth upstreaming? I used it in my project to add support for inline latex insertions.
I tried to make the least invasive variant possible, and the main questionable parts are as follows:
Hashableconformance inCustomInlineis not guaranteed in any way (and no idea how to do that)CustomInlineusesSwiftUI.Text, whileInlineNodedidn't depend onSwiftUIbeforeIn any case, looking forward for your feedback!