Skip to content

Move updateref and removeref to gitrepo and remove unnecessary open repository #35511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 19, 2025
Merged

Move updateref and removeref to gitrepo and remove unnecessary open repository #35511

merged 7 commits into from
Sep 19, 2025
+46 −47

Conversation

lunny
Copy link
Member

@lunny lunny commented Sep 18, 2025 •
edited
Loading

Extracted from #35077
UpdateRef and RemoveRef will call git commands even for gogit version.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Sep 18, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 18, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Sep 18, 2025
@github-actions github-actions bot added the modifies/api This PR adds API routes or modifies them label Sep 18, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 18, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 18, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 19, 2025
@lunny lunny added this to the 1.25.0 milestone Sep 19, 2025
@lunny lunny merged commit 198f37e into go-gitea:main Sep 19, 2025
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

+1 more reviewer

@hiifong hiifong hiifong approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lunny @techknowlogick @hiifong @GiteaBot