-
-
Notifications
You must be signed in to change notification settings - Fork 6k
Add environments and deployments to the actions. #35336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
f04f0e3
to
7147169
Compare
models/migrations/migrations.go
Outdated
|
||
// Gitea 1.24.0 ends at database version 321 | ||
newMigration(321, "Use LONGTEXT for some columns and fix review_state.updated_files column", v1_25.UseLongTextInSomeColumnsAndFixBugs), | ||
// Gitea 1.25.0 starts at database version 322 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// Gitea 1.25.0 starts at database version 322 |
models/migrations/migrations.go
Outdated
newMigration(321, "Use LONGTEXT for some columns and fix review_state.updated_files column", v1_25.UseLongTextInSomeColumnsAndFixBugs), | ||
// Gitea 1.25.0 starts at database version 322 | ||
newMigration(322, "Create action_environment table for deployment environments", v1_25.CreateActionEnvironmentTable), | ||
newMigration(323, "Create action_deployment table for deployment tracking", v1_25.CreateActionDeploymentTable), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge the two migrations into one.
return | ||
} | ||
|
||
form := web.GetForm(ctx).(*forms.AddSecretForm) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
form := web.GetForm(ctx).(*forms.AddSecretForm) | |
form := web.GetForm(ctx).(*forms.AddEnvironmentForm) |
templates/repo/actions/view.tmpl
Outdated
)}} | ||
</div> | ||
|
||
{{if .AutoRerun}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AutoRerun should be another feature? If that, it's better to split it into another PR.
</div> | ||
</div> | ||
{{end}} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move it to another sub template.
Thanks for the feedback. I will address these :) |
bd88a10
to
fd25c32
Compare
This implements go-gitea#30079
Signed-off-by: Nick Humrich <nick.humrich@gmail.com>
This implements #30079
Screenshots:

example workflow file showing two different syntaxes for environments (as supported by github):