Skip to content

Conversation

cogk
Copy link
Contributor

@cogk cogk commented Aug 4, 2025

Shell characters can cause issues because they are not escaped in the bench new-site command

https://stackoverflow.com/questions/15783701/which-characters-need-to-be-escaped-when-using-bash/44581064#44581064

Example with abc$defgh&QSDF:

{
    "command": "docker exec -w /home/frappe/frappe-bench  bench-****-******-** bench new-site --no-mariadb-socket --mariadb-root-username _****************_limited --mariadb-root-password **************** --admin-password abc$defgh&QSDF --db-name _**************** ***************.example.cloud",
    "directory": "/home/frappe/benches/bench-****-******-**",
    "duration": "0:00:00.260719",
    "end": "2025-08-04 11:50:09.592477",
    "output": "/bin/sh: 1: QSDF: not found\nUsage: bench  new-site [OPTIONS] SITE\nTry 'bench  new-site --help' for help.\n\nError: Missing argument 'SITE'.",
    "returncode": 127,
    "start": "2025-08-04 11:50:09.331758",
    "status": "Failure",
    "traceback": "..."
}

@cogk cogk requested a review from balamurali27 as a code owner August 4, 2025 13:12
@cogk cogk marked this pull request as draft August 4, 2025 13:13
Copy link

codecov bot commented Aug 4, 2025

Codecov Report

❌ Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 35.40%. Comparing base (6f82b05) to head (b7f5641).
⚠️ Report is 701 commits behind head on develop.

Files with missing lines Patch % Lines
press/press/doctype/site/site.py 77.77% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2886   +/-   ##
========================================
  Coverage    35.39%   35.40%           
========================================
  Files          431      431           
  Lines        35773    35784   +11     
========================================
+ Hits         12662    12669    +7     
- Misses       23111    23115    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cogk cogk force-pushed the feat-validate-admin-password branch from b7b838e to b7f5641 Compare August 4, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant