Skip to content

Conversation

MarkDuckworth
Copy link
Contributor

@MarkDuckworth MarkDuckworth commented Sep 5, 2025

This release of closure includes two fixes:

  1. Increased the buffering-proxy detection timeout to minimize the false-positive rate
  2. Updating WebChannel to ignore duplicate messages received from the server. Fix FIRESTORE (10.12.0) INTERNAL ASSERTION FAILED: Unexpected state #8250

@MarkDuckworth MarkDuckworth requested review from a team as code owners September 5, 2025 21:27
Copy link

changeset-bot bot commented Sep 5, 2025

🦋 Changeset detected

Latest commit: 8e1e557

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@firebase/webchannel-wrapper Patch
@firebase/firestore Patch
firebase Patch
@firebase/firestore-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MarkDuckworth MarkDuckworth requested a review from a team as a code owner September 5, 2025 21:30
Copy link
Contributor

github-actions bot commented Sep 5, 2025

Changeset File Check ✅

  • No modified packages are missing from the changeset file.
  • No changeset formatting errors detected.

@MarkDuckworth MarkDuckworth changed the title Update closure-net dependency to the latest release chore(firestore): Update closure-net dependency to the latest release Sep 5, 2025
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 5, 2025

Size Report 1

Affected Products

  • @firebase/ai

    TypeBase (55f3f83)Merge (5dc762d)Diff
    browser61.3 kB62.4 kB+1.18 kB (+1.9%)
    main64.8 kB66.1 kB+1.29 kB (+2.0%)
    module61.3 kB62.4 kB+1.18 kB (+1.9%)
  • @firebase/remote-config

    TypeBase (55f3f83)Merge (5dc762d)Diff
    browser22.7 kB39.0 kB+16.3 kB (+71.6%)
    main23.9 kB40.2 kB+16.4 kB (+68.7%)
    module22.7 kB39.0 kB+16.3 kB (+71.6%)
  • @firebase/webchannel-wrapper/bloom-blob

    TypeBase (55f3f83)Merge (5dc762d)Diff
    browser11.1 kB11.3 kB+123 B (+1.1%)
    main11.1 kB11.3 kB+123 B (+1.1%)
    module11.1 kB11.3 kB+123 B (+1.1%)
  • @firebase/webchannel-wrapper/webchannel-blob

    TypeBase (55f3f83)Merge (5dc762d)Diff
    browser42.2 kB40.9 kB-1.27 kB (-3.0%)
    main42.2 kB40.9 kB-1.27 kB (-3.0%)
    module42.2 kB40.9 kB-1.27 kB (-3.0%)
  • bundle

    16 size changes

    TypeBase (55f3f83)Merge (5dc762d)Diff
    firestore (CSI Auto Indexing Disable and Delete)287 kB286 kB-1.16 kB (-0.4%)
    firestore (CSI Auto Indexing Enable)287 kB286 kB-1.16 kB (-0.4%)
    firestore (Persistence)319 kB318 kB-1.16 kB (-0.4%)
    firestore (Query Cursors)258 kB257 kB-1.16 kB (-0.4%)
    firestore (Query)256 kB255 kB-1.16 kB (-0.5%)
    firestore (Read data once)246 kB245 kB-1.16 kB (-0.5%)
    firestore (Read Write w Persistence)339 kB338 kB-1.16 kB (-0.3%)
    firestore (Realtime updates)246 kB245 kB-1.16 kB (-0.5%)
    firestore (Transaction)224 kB223 kB-1.16 kB (-0.5%)
    firestore (Write data)226 kB224 kB-1.16 kB (-0.5%)
    firestore-lite (Query Cursors)110 kB110 kB+123 B (+0.1%)
    firestore-lite (Query)106 kB106 kB+123 B (+0.1%)
    firestore-lite (Read data once)81.5 kB81.6 kB+123 B (+0.2%)
    firestore-lite (Transaction)107 kB107 kB+123 B (+0.1%)
    firestore-lite (Write data)91.0 kB91.1 kB+123 B (+0.1%)
    remote-config (getAndFetch)47.8 kB59.4 kB+11.7 kB (+24.4%)

  • firebase

    TypeBase (55f3f83)Merge (5dc762d)Diff
    firebase-ai.js48.4 kB49.3 kB+919 B (+1.9%)
    firebase-compat.js800 kB809 kB+9.35 kB (+1.2%)
    firebase-firestore-compat.js349 kB348 kB-1.18 kB (-0.3%)
    firebase-firestore-lite.js138 kB138 kB+132 B (+0.1%)
    firebase-firestore.js455 kB454 kB-1.11 kB (-0.2%)
    firebase-remote-config-compat.js27.9 kB38.7 kB+10.8 kB (+38.5%)
    firebase-remote-config.js32.2 kB43.5 kB+11.3 kB (+35.1%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/uH39bvzc6e.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 5, 2025

Size Analysis Report 1

This report is too large (137,370 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/QdffpZRPYB.html

Copy link
Contributor

@ehsannas ehsannas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks Mark!

@duncannz
Copy link

I don't quite understand how a change to dev dependencies only has any impact, unless I'm misunderstanding something? Is there something like a build script that needs to be run using the updated dev dependency?

@MarkDuckworth MarkDuckworth merged commit 43276b0 into main Sep 16, 2025
60 of 64 checks passed
@MarkDuckworth MarkDuckworth deleted the markduckworth/update-closure-net-message-dedup branch September 16, 2025 21:07
@google-oss-bot google-oss-bot mentioned this pull request Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FIRESTORE (10.12.0) INTERNAL ASSERTION FAILED: Unexpected state
5 participants