Skip to content

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Sep 7, 2025

Resolved / Related Issues

Steps used to test these changes

  • Build the app
  • Cold-launch the app
  • See its jump list being the same as the Explorer's jump list
  • Pin/unpin an item from the Explorer's jump list
  • See that of Files also gets updated
  • Do the way around of above
image image

@0x5bfa 0x5bfa force-pushed the 5bfa/CQ-JumpListManager branch from 71afbb3 to 9eb7ae9 Compare September 7, 2025 17:00
@0x5bfa 0x5bfa changed the title Code Quality: Sync the jump list with Explorer Code Quality: Sync the jump list with Explorer at the startup Sep 7, 2025
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this code used at all? If not, we can remove it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah used.

<Extension Category="windows.updateTask" EntryPoint="Files.App.BackgroundTasks.UpdateTask" />

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may need to put something in place to prevent stale jumplists after updating Files or Windows.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do the same as what we do at the startup, clear all and fetch items from Explorer.
Should we do it?

Copy link
Member

@yaira2 yaira2 Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the update task run even if Files is closed? In that case, I think we should do this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now when the app is updated, the old jump list will be deleted and re-fetched from Explorer.

@0x5bfa 0x5bfa marked this pull request as draft September 9, 2025 19:04
@yaira2 yaira2 force-pushed the main branch 2 times, most recently from 97999e5 to 806f922 Compare September 9, 2025 21:12
@0x5bfa 0x5bfa force-pushed the 5bfa/CQ-JumpListManager branch 2 times, most recently from 813d167 to 278a971 Compare September 11, 2025 09:42
@0x5bfa 0x5bfa force-pushed the 5bfa/CQ-JumpListManager branch from 278a971 to 33efe98 Compare September 11, 2025 09:45
@0x5bfa 0x5bfa marked this pull request as ready for review September 11, 2025 09:45
@0x5bfa 0x5bfa changed the title Code Quality: Sync the jump list with Explorer at the startup Code Quality: Sync the jump list with Explorer Sep 14, 2025
@yaira2
Copy link
Member

yaira2 commented Sep 14, 2025

This might help with #14526

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Files is pinned to my taskbar. When I right click on it, I'd like to see my quick access pins and pins I make
2 participants