Fix ARM64 emulation support in all entrypoints #587
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
scenario.sh
andscenario2map.sh
entrypointssetup-exec.sh
script to handle ARM64 emulation logic consistentlyProblem
Issue #585 identified that
scenario.sh
andscenario2map.sh
were not using the ARM64 emulation logic (box64) that was present indocker-entrypoint.sh
. This caused these entrypoints to fail on ARM64 platforms.Solution
setup-exec.sh
that handles the ARM64 emulation setupscenario.sh
- now supports ARM64 emulationscenario2map.sh
- now supports ARM64 emulationdocker-entrypoint.sh
- refactored to use shared scriptdocker-entrypoint-rootless.sh
- refactored to use shared scriptTest plan
Files changed
docker/files/setup-exec.sh
- New shared script for ARM64 emulationdocker/files/scenario.sh
- Updated to use shared emulation logicdocker/files/scenario2map.sh
- Updated to use shared emulation logicdocker/files/docker-entrypoint.sh
- Refactored to use shared scriptdocker/files/docker-entrypoint-rootless.sh
- Refactored to use shared scriptFixes #585
🤖 Generated with Claude Code