-
Notifications
You must be signed in to change notification settings - Fork 7.7k
fix(hash): add selective build option for Hash, WebServer dependency #11854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Hello fill1890, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
@lucasssvaz PTAL |
The Hash library introduced in version v3.3.1 doesn't have an option to be included in a selective build, and in a selective build it defaults to not included. As the WebServer library depends on the Hash library, selective builds that include WebServer break as the dependency is not satisfied.
This PR adds an appropriate option to Kconfig, and adds the WebServer → Hash dependency.
Tested on a selective build using the Arduino core as an ESP-IDF component on an ESP32-S3. As far as I know the aren't any open issues for this.