Skip to content

Conversation

me-no-dev
Copy link
Member

This pull request adds support for the LAN867x Ethernet PHY to the ESP32 platform. The changes include updating dependencies, conditionally enabling code for the new PHY, and integrating it into the Ethernet library's initialization and configuration logic.

LAN867x PHY Support Integration:

  • Added espressif/lan867x as a dependency in idf_component.yml, limited to ESP32 and ESP32P4 targets.
  • Defined ETH_PHY_LAN867X_SUPPORTED macro in ETH.h when esp_eth_phy_lan867x.h is available, enabling conditional compilation for LAN867x support.
  • Added ETH_PHY_LAN867X to the eth_phy_type_t enum, making it selectable as a PHY type.
  • Included esp_eth_phy_lan867x.h and added case handling for ETH_PHY_LAN867X in the Ethernet initialization logic, allowing the library to instantiate and use the LAN867x PHY. [1] [2]

Closes: espressif/esp32-arduino-lib-builder#319

@me-no-dev me-no-dev requested a review from SuGlider as a code owner September 16, 2025 08:48
@me-no-dev me-no-dev added the Status: Review needed Issue or PR is awaiting review label Sep 16, 2025
Copy link
Contributor

github-actions bot commented Sep 16, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello me-no-dev, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 065f920

Copy link
Contributor

github-actions bot commented Sep 16, 2025

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32C50⚠️ +980.00⚠️ +0.01000.000.00
ESP32P40⚠️ +1040.00⚠️ +0.01000.000.00
ESP32S30⚠️ +480.000.00000.000.00
ESP32S20⚠️ +440.000.00000.000.00
ESP32C30⚠️ +980.00⚠️ +0.01000.000.00
ESP32C60⚠️ +1000.00⚠️ +0.01000.000.00
ESP32H2000.000.00000.000.00
ESP320⚠️ +440.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32C5ESP32P4ESP32S3ESP32S2ESP32C3ESP32C6ESP32H2ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
libraries/Ethernet/examples/ETH_W5500_Arduino_SPI0000000000000000
libraries/Ethernet/examples/ETH_W5500_IDF_SPI0000000000000000
libraries/Ethernet/examples/ETH_WIFI_BRIDGE⚠️ +980⚠️ +1040⚠️ +480⚠️ +440⚠️ +980⚠️ +1000--⚠️ +440
libraries/Ethernet/examples/ETH_TLK110--00----------00
libraries/Ethernet/examples/ETH_LAN8720--------------00

Copy link
Contributor

github-actions bot commented Sep 16, 2025

Test Results

 76 files   76 suites   13m 11s ⏱️
 38 tests  38 ✅ 0 💤 0 ❌
241 runs  241 ✅ 0 💤 0 ❌

Results for commit 065f920.

♻️ This comment has been updated with latest results.

Copy link
Member

@lucasssvaz lucasssvaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@me-no-dev me-no-dev added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Sep 16, 2025
@me-no-dev me-no-dev merged commit d17f9c0 into master Sep 16, 2025
68 checks passed
@me-no-dev me-no-dev deleted the feature/lan867x branch September 16, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants