feat(zigbee): Add Write Response Handler + option to allow multi endpoint binding #11817
Conversation
P-R-O-C-H-Y
added
Status: Review needed
👋 Hello P-R-O-C-H-Y, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Test Results 76 files 76 suites 13m 8s ⏱️ Results for commit 93c5e9f. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces support for Zigbee write attribute response handling and adds an option to allow multi-endpoint binding in the Zigbee core. The write response handler enables applications to receive and process attribute write confirmations, while the multi-endpoint binding option (disabled by default) allows endpoints to bind to multiple devices for advanced use cases.
Key changes:
- Added write attribute response handler with callback mechanism
- Introduced multi-endpoint binding configuration option
- Enhanced device binding logic to support multiple endpoints when enabled
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ZigbeeHandlers.cpp | Added write attribute response handler function and callback registration |
| ZigbeeEP.h | Added virtual zbWriteAttributeResponse method for endpoint implementations |
| ZigbeeCore.h | Added multi-endpoint binding configuration methods |
| ZigbeeCore.cpp | Enhanced binding logic with multi-endpoint support and configuration initialization |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
me-no-dev
added
Status: Pending Merge
Description of Change
This pull request introduces support for multi-endpoint binding in the Zigbee core, and adds handling for Zigbee write attribute response messages. The changes improve the flexibility of Zigbee device binding and enhance attribute response handling, making it easier to support advanced Zigbee features. The
multi-endpoint bindingoption is disabled by default, to keep backward compatibility and also its not standard for Smart Home devices when using HA, only for specific scenarios.Test Scenarios
Tested using custom example with 2 ESP-C6 (Coordinator + End Device)
Related links