Skip to content

Do not allow client to modify whitespace for auto insert edits #8588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 10, 2025
Merged

Do not allow client to modify whitespace for auto insert edits #8588

merged 6 commits into from
Sep 10, 2025

Conversation

dibarbet
Copy link
Member

@dibarbet dibarbet commented Sep 6, 2025 •
edited
Loading

Tell the client not to modify the whitespace we provided in auto insert snippets.
Requires dotnet/roslyn#80075

@dibarbet dibarbet mentioned this pull request Sep 6, 2025
Merged
@dibarbet dibarbet changed the title Do now allow client to modify whitespace for auto insert edits Do not allow client to modify whitespace for auto insert edits Sep 8, 2025
@dibarbet dibarbet force-pushed the fix_on_auto_insert_whitespace branch from ffb9364 to c5ab09c Compare September 9, 2025 18:42
@dibarbet dibarbet force-pushed the fix_on_auto_insert_whitespace branch from c854d76 to 11bb070 Compare September 9, 2025 18:47
@dibarbet dibarbet marked this pull request as ready for review September 9, 2025 19:56
@dibarbet dibarbet requested a review from a team as a code owner September 9, 2025 19:56
JoeRobich
JoeRobich reviewed Sep 9, 2025
View reviewed changes
JoeRobich
JoeRobich reviewed Sep 9, 2025
View reviewed changes
JoeRobich
JoeRobich reviewed Sep 9, 2025
View reviewed changes
Copy link
Member

@JoeRobich JoeRobich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test to the onAutoInsert integration tests?

@dibarbet dibarbet force-pushed the fix_on_auto_insert_whitespace branch from db3bf84 to 025c9fa Compare September 10, 2025 00:39
JoeRobich
JoeRobich approved these changes Sep 10, 2025
View reviewed changes
Copy link
Member

@JoeRobich JoeRobich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just be sure to remove the commented out code.

@dibarbet @JoeRobich
Update src/lsptoolshost/autoInsert/onAutoInsert.ts
4cca94a 
Co-authored-by: Joey Robichaud <joseph.robichaud@microsoft.com>
@dibarbet dibarbet enabled auto-merge September 10, 2025 18:43
@dibarbet dibarbet disabled auto-merge September 10, 2025 20:40
@dibarbet dibarbet merged commit fbda94a into dotnet:main Sep 10, 2025
29 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeRobich JoeRobich JoeRobich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dibarbet @JoeRobich