Dotnet vscode csharp insertion #8563
Conversation
|
This will create pr like deepakrathore33@3bbf97f |
There was a problem hiding this comment.
LGTM, heads-up: there's another PR here that we'd want to de-dupe some of the git helpers with. Happy to chat offline.
Co-authored-by: Joey Robichaud <joseph.robichaud@microsoft.com>
tasks/gitHelpers.ts
Outdated
| console.log(`##vso[task.logissue type=error]${message}`); | ||
| } | ||
|
|
||
| export async function git(args: string[], printCommand = true): Promise<string> { |
There was a problem hiding this comment.
Some of this is now similar to https://github.com/dotnet/vscode-csharp/blob/main/tasks/gitTasks.ts. Can we please move unique functions from here to there please? getCommitFromNugetAsync seems like the main thing that is missing. Although, I don't think that is a function of git in any way, so maybe that needs another home.
tasks/gitHelpers.ts
Outdated
| } | ||
| } | ||
|
|
||
| export async function createBranchAndPR( |
There was a problem hiding this comment.
The newer API here has different methods for pushing a branch, checking if it exists and creating PR, so when you adopt that you'd want to change the callers as well.
JoeRobich
force-pushed
the
dev/aajohn/relautomation
branch
from
7c610f6 to
29cb53a
Compare
| - task: Npm@1 | ||
| displayName: Run Roslyn insertion | ||
| env: | ||
| GitHubPAT: $(BotAccount-dotnet-bot-repo-PAT) |
There was a problem hiding this comment.
I see that we are passing this as a command line argument. Do we also need it as a variable?
There was a problem hiding this comment.
I think we don't need it. Not sure if I have used env variable somewhere, let me check it and remove it
Uh oh!
There was an error while loading. Please reload this page.