Skip to content

Conversation

baronfel
Copy link
Member

@baronfel baronfel commented Sep 3, 2025

Just a bit of fit and finish ahead of the upcoming release.

Comment on lines +222 to +224
### Breaking Changes
- Default value handling for `ProcessTerminationTimeout` has been re-added ([#2672](https://github.com/dotnet/command-line-api/pull/2672))
- Some internal APIs have been refactored to reduce reflection usage ([#2662](https://github.com/dotnet/command-line-api/pull/2662))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you set a custom action on a HelpOption or VersionOption, the option no longer clears parse errors implicitly. To restore the previous behaviour, make the action class override the CommandLineAction.ClearsParseErrors property to return true.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ViktorHofer please list this as a breaking change in the 2.0.0-rc.1.25451.107 release notes, too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release notes are auto-generated but we can include those, yes. @adamsitnik would you mind updating the release note for RC1? I don't have context on these changes.

Copy link

@KalleOlaviNiemitalo KalleOlaviNiemitalo Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ProcessTerminationTimeout change was rejected for RC1 (#2673) so it should not be added to the RC1 release notes.

Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big thanks for adding the README.md @baronfel !

baronfel and others added 2 commits September 11, 2025 10:18
Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, :shipit: !

## Notable Changes Since v2.0.0-beta7

### New Features
- **Finnish Localization**: Added Finnish language translations for help text and error messages ([#2605](https://github.com/dotnet/command-line-api/pull/2605))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better remove the Finnish localization from the change log until it is actually included in the package; see #2587 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants