-
Notifications
You must be signed in to change notification settings - Fork 405
Add package readme for the core System.CommandLine package #2679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/10.0
Are you sure you want to change the base?
Conversation
### Breaking Changes | ||
- Default value handling for `ProcessTerminationTimeout` has been re-added ([#2672](https://github.com/dotnet/command-line-api/pull/2672)) | ||
- Some internal APIs have been refactored to reduce reflection usage ([#2662](https://github.com/dotnet/command-line-api/pull/2662)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you set a custom action on a HelpOption or VersionOption, the option no longer clears parse errors implicitly. To restore the previous behaviour, make the action class override the CommandLineAction.ClearsParseErrors property to return true.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ViktorHofer please list this as a breaking change in the 2.0.0-rc.1.25451.107 release notes, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The release notes are auto-generated but we can include those, yes. @adamsitnik would you mind updating the release note for RC1? I don't have context on these changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ProcessTerminationTimeout
change was rejected for RC1 (#2673) so it should not be added to the RC1 release notes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big thanks for adding the README.md @baronfel !
Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, !
## Notable Changes Since v2.0.0-beta7 | ||
|
||
### New Features | ||
- **Finnish Localization**: Added Finnish language translations for help text and error messages ([#2605](https://github.com/dotnet/command-line-api/pull/2605)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better remove the Finnish localization from the change log until it is actually included in the package; see #2587 (comment).
Just a bit of fit and finish ahead of the upcoming release.