-
Notifications
You must be signed in to change notification settings - Fork 25.1k
Environments article overhaul #36022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR completely overhauls the ASP.NET Core environments documentation article to improve its organization, add new content for Docker scenarios, and modernize the guidance. The update addresses two GitHub issues (#35807 and #31962) by restructuring the content with a more logical flow and adding comprehensive Docker environment configuration guidance.
Key changes include:
- Restructured the article with a clearer outline focusing on environments, control mechanisms, and setting approaches
- Added comprehensive Docker guidance (Dockerfile, Docker Compose, docker run, environment files)
- Consolidated versioned content while maintaining support for Startup class patterns
- Updated Azure App Service guidance to reference external documentation
This comment was marked as outdated.
This comment was marked as outdated.
Co-authored-by: Daniel Roth <daroth@microsoft.com>
@danroth27 ... Updates made. Another look before asking Javier to look?
UPDATE: That last commit addresses the RP/MVC piece. |
@tdykstra ... I think we're still planning on getting a technical review from Javier, but you can review anytime. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Fixes #35807
Fixes #31962
Startup
class magic ✨ ... We'll keep it for now. It's going to go away at some point in the future.The initial outline for the article on the PR ...
dotnet run
)launchSettings.json
)docker run
commandStartup
classStartup
class methodsInternal previews