Settings: Open file dialogs at user path instead of custom path #13926
+7
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When opening a file dialog to set the location of a custom path, use the corresponding user path as the starting location instead of the current custom path. When no custom path was set the dialog would be opened with a blank path which causes Windows (not sure about other platforms) to open the dialog at the same location where the last dialog was closed, or at the current working directory if no previous dialog had been opened. If a nonempty custom path has been set then it has also set the corresponding user path, so the behavior in that case is unchanged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When opening a file dialog to set the location of a custom path, use the corresponding user path as the starting location instead of the current custom path.
When no custom path was set the dialog would previously be opened with a blank path. This causes Windows (not sure about other platforms) to open the dialog at the same location where the last dialog was closed, or at the current working directory if no previous dialog had been opened.
If a nonempty custom path has been set then it has also set the corresponding user path, so the behavior in that case is unchanged.
This also creates
D_WFSROOT_IDXinUICommon::CreateDirectoriesso that there's a folder to go to when opening that dialog.