DEV: Adding specs and refactors #21
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-brennan
commented
Sep 3, 2025
martin-brennan
commented
- DEV: Adding specs for all reports, spec helpers, and minor refactors
- DEV: Refactor BestPosts
martin-brennan
changed the title
Return an array of hashes instead of an array of arrays, this simplifies the component too. Also, remove unnecessary htmlSafe in the component.
martin-brennan
force-pushed
the
dev/adding-specs-and-refactors
branch
from
e1c745b to
31cef0d
Compare
Also make it so we limit the amount of words returned on the server, no point returning 100 to the client and slicing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.