Skip to content

fix: add support for ktfmt's TrailingCommaManagementStrategy #2613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix: add support for ktfmt's TrailingCommaManagementStrategy #2613

wants to merge 6 commits into from

Conversation

greyhairredbear
Copy link

@greyhairredbear greyhairredbear commented Sep 6, 2025 •
edited by Goooler
Loading

and makes #2400 obsolete

Important Note: This PR also upgrades the JVM version in gradle/java-publish.gradle and gradle.properties from 11 to 17

TODO

  • extra tests for KtfmtStepTest
    • trailing comma management strategy ONLY_ADD
    • Not sure if necessary: Test for versions between 0.53 (previous default) and 0.57 (or 0.58). Maybe @hick209 or someone from the ktfmt team has an opinion if that is sensible or what to test here.
  • ensure KtfmtTest from Maven plugin test passes
  • CHANGES.md files

@greyhairredbear greyhairredbear marked this pull request as ready for review September 6, 2025 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@greyhairredbear