Skip to content

Conversation

xvrh
Copy link

@xvrh xvrh commented Feb 20, 2025

Fixes #801

Have the generator correctly generate dummy return value for Future<ExtensionType>

Before, the generators would return: _i2.Future<_i3.Ext>.value((0)) (which won't compile). After, it will generate a cast from the representation dummy value: _i2.Future<_i3.Ext>.value((0 as _i3.Ext))


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@xvrh xvrh force-pushed the xha/support_extension_type_future branch from b75ffbd to c79e8e8 Compare February 20, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Returning a Future<ExtensionType> generates invalid code
1 participant