Better warnings and errors logging. #4190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with |
davidmorgan
force-pushed
the
really-tweak-warnings-errors
branch
from
6bb1939 to
0ace907
Compare
jensjoha
approved these changes
Sep 5, 2025
| var first = true; | ||
| for (final line in message.text.split('\n')) { | ||
| result.add( | ||
| AnsiBufferLine([ | ||
| if (message.severity == Severity.error) AnsiBuffer.boldRed, |
There was a problem hiding this comment.
(maybe mostly because of the github interface, I'm not sure): This would read better if message.severity == Severity.error was up with var first, e.g. final isError = message.severity == Severity.error; and then here if (isError) AnsiBuffer.boldRead.
There was a problem hiding this comment.
Works for me. Thanks :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #4127
Changes to make failures more prominent/actionable:
And, remove the "deleting declared outputs" warning, it's not actionable.