Skip to content

feat(external-link): adding target attribute #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat(external-link): adding target attribute #22

wants to merge 3 commits into from

Conversation

vettndr
Copy link

@vettndr vettndr commented Nov 10, 2021

Checking an external link.

@vettndr vettndr mentioned this pull request Nov 10, 2021
Open
@vettndr vettndr changed the title feat(external-link): adding target attributes feat(external-link): adding target attribute Nov 10, 2021
daliborgogic
daliborgogic requested changes Nov 11, 2021
View reviewed changes
Copy link
Owner

@daliborgogic daliborgogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Strict inequality !==

@vettndr
Copy link
Author

vettndr commented Nov 11, 2021 •
edited
Loading

Strict inequality added.
In the external link check I added the empty target condition to skip the new code block if there is a target.

@daliborgogic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daliborgogic daliborgogic daliborgogic requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vettndr @daliborgogic