Update docker-compose.yml #34
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed DNS settings which pointed to `1.1.1.1`, since direct connections to `1.1.1.1` bypasses DoH. Queries should only go through cloudflared, which is `172.20.0.3` in this example
ilopmar
reviewed
Feb 7, 2023
| @@ -10,7 +10,6 @@ services: | |||
| ipv4_address: 172.20.0.2 | |||
| dns: | |||
| - 127.0.0.1 | |||
| - 1.1.1.1 | |||
There was a problem hiding this comment.
Without this line I see the following errors when pihole container starts:
...
pihole | Checking if custom gravity.db is set in /etc/pihole/pihole-FTL.conf
pihole | Skipping Gravity Database Update.
pihole |
pihole | s6-rc: info: service legacy-services successfully started
pihole | fatal: unable to access 'https://github.com/pi-hole/pi-hole/': Could not resolve host: github.com
pihole | fatal: unable to access 'https://github.com/pi-hole/AdminLTE/': Could not resolve host: github.com
pihole | fatal: unable to access 'https://github.com/pi-hole/FTL/': Could not resolve host: github.com
pihole | Pi-hole version is v5.15.3 (Latest: null)
pihole | AdminLTE version is v5.18.3 (Latest: null)
pihole | FTL version is v5.20.1 (Latest: null)
pihole | Container tag is: 2023.01.10
Then if I docker exec into the pihole container a ping command fails to resolve the name:
$ docker exec -it pihole bash
root@pihole:/# ping google.com
ping: google.com: Temporary failure in name resolution
Adding back that 1.1.1.1 dns entry the startup looks good:
...
pihole | s6-rc: info: service legacy-services: starting
pihole | Checking if custom gravity.db is set in /etc/pihole/pihole-FTL.conf
pihole | Skipping Gravity Database Update.
pihole |
pihole | s6-rc: info: service legacy-services successfully started
pihole | Pi-hole version is v5.15.3 (Latest: null)
pihole | AdminLTE version is v5.18.3 (Latest: null)
pihole | FTL version is v5.20.1 (Latest: null)
pihole | Container tag is: 2023.01.10
Now the ping works:
$ docker exec -it pihole bash
root@pihole:/# ping google.com
PING google.com (142.250.200.78) 56(84) bytes of data.
64 bytes from mad07s24-in-f14.1e100.net (142.250.200.78): icmp_seq=1 ttl=249 time=3.66 ms
64 bytes from mad07s24-in-f14.1e100.net (142.250.200.78): icmp_seq=2 ttl=249 time=4.13 ms
...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed DNS settings which pointed to
1.1.1.1, since direct connections to1.1.1.1bypasses DoH.Queries should instead go through cloudflared only, which is
172.20.0.3in this example.I've tested it in my system using https://dnsleaktest.com.