refactor(compose): Optimize cycle detection in DAG validation #371
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request optimizes the cycle detection algorithm in the validateDAG
function by replacing the existing implementation with a more efficient
depth-first search (DFS) based approach.
Previously, the function used a map to store the in-degree of each node and
then iteratively removed nodes with an in-degree of 0. This approach has a
time complexity of O(V + E), where V is the number of vertices and E is the
number of edges. The new implementation uses a DFS-based approach, which is
generally faster in practice while having the same time complexity.
Changes:
compose/graph.go
: Replaced the existing validateDAG function with a moreefficient implementation that uses a depth-first search (DFS) to detect
cycles.
This optimization improves the performance of the graph compilation process,
especially for large and complex graphs.