Revert "chore: installing pnpm instead of relying on cache" #114
Conversation
This reverts commit f5dd09b.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Greptile Summary
This PR reverts changes made to the GitHub Actions release workflow configuration in .github/workflows/release.yml. The revert undoes modifications to the order of pnpm and Node.js setup steps, moving pnpm setup back to after Node.js setup and re-enabling the pnpm cache in the setup-node action.
The original change (PR #113) had modified the workflow to install pnpm before setting up Node.js and disabled the pnpm cache to avoid circular dependency issues. However, that change apparently broke pnpm installation in releases, prompting this revert. The current configuration now has Node.js setup first with cache: 'pnpm' enabled, followed by pnpm installation using pnpm/action-setup@v4.
This workflow is part of the project's CI/CD pipeline and is responsible for handling package management and dependency installation during the release process. The workflow configuration is critical for ensuring that releases can be built and published successfully.
Confidence score: 2/5
- This PR introduces a logical inconsistency where Node.js setup attempts to use pnpm cache before pnpm is actually installed
- Score reflects the circular dependency issue created by trying to cache pnpm dependencies before pnpm installation
- Pay close attention to
.github/workflows/release.ymland monitor release workflow executions
1 file reviewed, 1 comment
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 20 | ||
| cache: 'pnpm' |
There was a problem hiding this comment.
logic: Setting cache: 'pnpm' before pnpm is installed (line 25-28) creates a logical dependency issue. The cache setup may fail or be ignored since pnpm isn't available yet.
Reverts #113