Skip to content

Conversation

cijiugechu
Copy link
Contributor

This Pull Request fixes/closes #1402 and #4089

It changes the following:

  • Added stacker to handle stack growth.
  • Added test suites.

Copy link

codecov bot commented Jun 28, 2025

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 50.16%. Comparing base (6ddc2b4) to head (a1f22b2).
Report is 446 commits behind head on main.

Files with missing lines Patch % Lines
core/parser/src/parser/expression/mod.rs 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4311      +/-   ##
==========================================
+ Coverage   47.24%   50.16%   +2.91%     
==========================================
  Files         476      496      +20     
  Lines       46892    49561    +2669     
==========================================
+ Hits        22154    24862    +2708     
+ Misses      24738    24699      -39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jasonwilliams
Copy link
Member

Thanks for this @cijiugechu
First I want to see if we can reduce the depths in some areas so we don’t need the segmented stacks. I’m experimenting with this in #4310 and am also looking at sub array case and areas where we can do parsing in the same level instead of depth.

I’ll keep this open though as we may want to fallback to this if those options don’t work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stack-overflow caused by deep call stack
2 participants