Skip to content

Conversation

inoue22
Copy link

@inoue22 inoue22 commented Jul 1, 2024

Update pom.xml and libraries; set minimum Java version to 11

  • Updated pom.xml to the latest version.
  • Upgraded libraries to their latest versions.
  • Changed the minimum required Java version to 11 to support the updated libraries.
  • Removed aws-kinesis-analytics-java-apps.iml due to the pom.xml update.

@inoue22
Copy link
Author

inoue22 commented Jul 26, 2024

@nicusX This has been open for almost a month. If you can view it and close or merge it, that would be great!

@nicusX nicusX self-assigned this Jul 29, 2024
@nicusX
Copy link
Contributor

nicusX commented Jul 29, 2024

Thanks for the PR @toco8
To really upgrade this example to 1.19, the new JDBC Connector should be used, rather than the obsolete Flink JDBC from Flink 1.10.
I am even surprised it still works.
The API has changed completely, and unfortunately it requires a substantial code change.

Also, the Maven plugins (maven-compiler-plugin and maven-shade-plugin) should be updated to a more recent version.

<groupId>org.apache.flink</groupId>
<artifactId>flink-jdbc_2.11</artifactId>
<version>${flink.version}</version>
<artifactId>flink-jdbc_${scala.binary.version}</artifactId>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrading to Flink 1.19 should replace the obsolete Flink JDBC org.apache.flink:flink-jdbc_2.12:1.10.3 with the new JDBC connector (org.apache.flink:flink-connector-jdbc:3.2.0-1.19) using the new API.

@inoue22
Copy link
Author

inoue22 commented Jul 31, 2024

Thank you for your review of the PR, @nicusX.
I will conduct an investigation over the weekend regarding the upgrade to 1.19, focusing on implementing the new JDBC Connector and updating the Maven plugins as you suggested. I aim to respond with my findings and proposed changes by August 6th.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants