Skip to content

Conversation

jaderfeijo
Copy link
Contributor

@jaderfeijo jaderfeijo commented May 14, 2024

Description

Update supported node version to include node ^22.1.0.

Note:

This PR follows on the changes from #142 which was rejected since node 21.7.1 was not LTS, whereas 22.1.0 should be.

Testing

  • Upgrade your local version of node to 22.1.0 (nvm install 22.1.0 if using nvm).
  • Running npm install installs all dependencies correctly (after upgrading to node 22.1.0).
  • Running npm run lint lints the project correctly.
  • Running npm run test runs all tests and all tests pass.

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch (I'm assuming the main branch is the correct, most up-to-date branch in this instance)

@jaderfeijo jaderfeijo requested a review from a team as a code owner May 14, 2024 08:49
@jaderfeijo jaderfeijo changed the title Add support for node 22.1.0 Add Support For Node 22.1.0 May 14, 2024
@db-at-work
Copy link

Can anyone approve this to get the latest node LTS release supported please ?

@houserx-jmcc houserx-jmcc mentioned this pull request Sep 5, 2024
4 tasks
@descampsk
Copy link

How can we help to make this PR merged :) ?

@jpshilton-op
Copy link

I'd really like this to be merged too, if possible.

@jaderfeijo jaderfeijo requested a review from a team as a code owner October 30, 2024 13:50
@jaderfeijo
Copy link
Contributor Author

I've updated the branch, but it needs approval from a maintainer so the pipelines can run again.

@jpshilton-op
Copy link

Are any maintainers willing to approve this?
Node 22 is the current LTS now.

@shide1989
Copy link

We're really bumping into this one. @kishore7snehil Do you think this PR is ok for merge ?

@jpshilton-op
Copy link

Has there been any movement on this?

@nhsiehgit
Copy link

another bump here!

node 18 will be EOL in April of this year
Meaning we're locked to only a single supported LTS

@nandan-bhat
Copy link
Contributor

Hello @jaderfeijo ,

Can you please sign the commits ? Currently your commits do not have verified signatures.

Reference: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

@nicolasiscoding
Copy link

Looks like it was added - 4428953

This can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants