-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Update serialization.md #1490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update serialization.md #1490
Conversation
Add enable_max_depth details
Co-authored-by: Kévin Dunglas <kevin@dunglas.fr>
Co-authored-by: Kévin Dunglas <kevin@dunglas.fr>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also provide an XML example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment from Dunglas to fix, then 👍
Co-authored-by: Kévin Dunglas <kevin@dunglas.fr>
I would suggest to target 4.0 branch instead of 3.4, WDYT @vinceAmstoutz @soyuka? |
IMHO |
Co-authored-by: Vincent <407859+vincentchalamon@users.noreply.github.com>
Co-authored-by: Vincent <407859+vincentchalamon@users.noreply.github.com>
Co-authored-by: Vincent <407859+vincentchalamon@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jzabrodin Could you please rebase with the 4.1
branch?
Add few details about max_depth and enable_max_depth