Skip to content

Conversation

szymonpachucki
Copy link

@szymonpachucki szymonpachucki commented Aug 24, 2025

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Now we can use indexes of custom values in formatter of axisLabel.

Fixed issues

[<!--

Details

We were not passing indexes to labelFormatter so when trying to use them in custom formatter we were just getting undefined.

Before: What was the problem?

On demo provided in the issue nothing would load due to using undefined in indexing.

After: How does it behave after the fixing?

Screenshot 2025-08-24 at 14 36 18

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

Copy link

echarts-bot bot commented Aug 24, 2025

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

Copy link
Contributor

@Ovilia Ovilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes looks good to me. Thanks! Please add a test case in test/axisLabel.html.

Copy link
Contributor

github-actions bot commented Sep 2, 2025

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-21220@792ce90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants