Use fs.FS interface #167
Open
Use fs.FS interface #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit allows using any fs.FS implementation.
anacrolix
reviewed
Aug 20, 2025
| if len(o.Path) == 1 { | ||
| return "0" | ||
| } | ||
| return url.QueryEscape(o.Path) | ||
| } | ||
|
|
||
| func (o *object) IsRoot() bool { | ||
| return o.Path == "/" | ||
| return o.Path == "." |
There was a problem hiding this comment.
Are you sure about changing this part? Same with the other usage. Can you make / rooted in whatever subtree fs.FS is?
There was a problem hiding this comment.
The . (dot) in the context of fs.FS generally refers to the root of the file system represented by that specific fs.FS instance. It is not necessarily the current working directory of the operating system, but rather the base or starting point of the abstract file system being exposed by the fs.FS implementation.
There was a problem hiding this comment.
Ah yeah, the interface I was going for was to expose / as the root of the FS exposed to the device. I understand . would be used on the server side that makes sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow using any fs.FS implementation.