Skip to content

Conversation

sgreenbury
Copy link
Collaborator

Contributes towards #513.

This PR adds:

  • DiscreteFourierTransform subclassing AutoEmulateTransform
  • Example usage in exploratory notebook comparing with PCA

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@sgreenbury sgreenbury force-pushed the 513-add-discrete-fourier-transform branch from 53bb957 to d4456c7 Compare July 28, 2025 17:45
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 96.32353% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.39%. Comparing base (cecf95d) to head (d4456c7).

Files with missing lines Patch % Lines
...mulate/experimental/transforms/discrete_fourier.py 93.75% 3 Missing ⚠️
autoemulate/experimental/compare.py 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #655      +/-   ##
==========================================
+ Coverage   80.20%   80.39%   +0.19%     
==========================================
  Files         155      157       +2     
  Lines       11132    11259     +127     
==========================================
+ Hits         8928     9052     +124     
- Misses       2204     2207       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  autoemulate/experimental
  compare.py 294-299
  autoemulate/experimental/transforms
  __init__.py
  discrete_fourier.py 157-162
  tests
  test_compare.py
  tests/experimental/transforms
  test_discrete_fourier.py
  test_serde.py
  test_transforms.py
Project Total  

This report was generated by python-coverage-comment-action

@sgreenbury sgreenbury force-pushed the 513-add-discrete-fourier-transform branch from d4456c7 to e763bc5 Compare August 20, 2025 09:02
@sgreenbury sgreenbury linked an issue Aug 20, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transforms for temporal data
2 participants