Skip to content

fix whitespace module execSync under Windows with no shebang #3100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

fix whitespace module execSync under Windows with no shebang #3100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8dc28c5
fix whitespace module execSync under Windows whih no shebang
zaycker Mar 4, 2025
ea10c71
stdio wasn't initially defined and windowsHide will be ignored under …
zaycker Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/eslint-config-airbnb-base/whitespace.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,13 @@ if (CLIEngine) {
} else {
const path = require('path');
const { execSync } = require('child_process');
const isWindows = process.platform === 'win32';
const whitespaceAsyncPath = path.join(__dirname, 'whitespace-async.js');
const execSyncCommand = isWindows ? `node ${whitespaceAsyncPath}` : whitespaceAsyncPath;

// NOTE: ESLint adds runtime statistics to the output (so it's no longer JSON) if TIMING is set
module.exports = JSON.parse(String(execSync(path.join(__dirname, 'whitespace-async.js'), {
module.exports = JSON.parse(String(execSync(execSyncCommand, {
windowsHide: true,
env: {
...process.env,
TIMING: undefined,
Expand Down
6 changes: 5 additions & 1 deletion packages/eslint-config-airbnb/whitespace.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,13 @@ if (CLIEngine) {
} else {
const path = require('path');
const { execSync } = require('child_process');
const isWindows = process.platform === 'win32';
const whitespaceAsyncPath = path.join(__dirname, 'whitespace-async.js');
const execSyncCommand = isWindows ? `node ${whitespaceAsyncPath}` : whitespaceAsyncPath;

// NOTE: ESLint adds runtime statistics to the output (so it's no longer JSON) if TIMING is set
module.exports = JSON.parse(String(execSync(path.join(__dirname, 'whitespace-async.js'), {
module.exports = JSON.parse(String(execSync(execSyncCommand, {
windowsHide: true,
env: {
...process.env,
TIMING: undefined,
Expand Down