fix(useCSSTransition): fix fast state changing #8890
Merged
+153
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ci:cherry-pick:patch
size-limit report 📦
|
e2e tests |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8890 +/- ##
=======================================
Coverage 96.02% 96.03%
=======================================
Files 428 428
Lines 12449 12472 +23
Branches 4105 4113 +8
=======================================
+ Hits 11954 11977 +23
Misses 495 495
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
👀 Docs deployed
📦 Package ✅yarn add @vkontakte/vkui@https://vkui-screenshot.hb.bizmrg.com/pull/8890/99fc17f872fa357c520d3caa0b4a0d337ad5be86/pkg/@vkontakte/vkui/_pkg.tgzCommit 99fc17f |
inomdzhon
reviewed
Aug 25, 2025
inomdzhon
reviewed
Aug 26, 2025
Там логика немного другая. Лучше, если будут кейсы, тогда поправим |
inomdzhon
reviewed
Aug 27, 2025
inomdzhon
reviewed
Aug 28, 2025
inomdzhon
approved these changes
Sep 1, 2025
BlackySoul
approved these changes
Sep 2, 2025
BlackySoul
reviewed
Sep 2, 2025
EldarMuhamethanov
deleted the
e.muhamethanov/8888/fix-fast-open-close-modal
branch
vkcom-publisher
pushed a commit
that referenced
this pull request
Sep 2, 2025
* fix(useCSSTransition): fix fast state changing * fix(useCSSTransition): fix import * fix: fix code review * fix: add condition when duration <= 0 * fix: delete useStateWithPrev * fix: add timer delay * test: fix test * test: add test * fix: use useIsomorphicLayoutEffect instead of useEffect * fix: use useIsomorphicLayoutEffect instead of useEffect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Исправляет баг, при котором компонент мог зависать в состоянии
exitingпри очень быстром открытии/закрытии (например: открыть → сразу закрыть). Корневая причина — полагание только на событиеtransitionend, которое в ряде реальных сценариев не гарантировано:transitionможет не стартовать (CSS-значения до/после совпадают), поэтомуtransitionendне придёт;transition-delayили задержки, которые разбегаются с ожиданиями в JS;display: noneдо конца анимации;transitionendгенерируется по каждому свойству и не всегда даёт простую семантику "анимация завершена" для корневого элемента.Из-за этого хук иногда оставался в
exiting— ниtransitionend, ни логика в JS не переводили состояние дальше.Изменения
getComputedStyle—transition-duration+transition-delay) и ставит fallback-таймер при входе в активные состояния (appearing,entering,exiting).transitionendприходит — таймер очищается и завершение происходит по событию. Если событие не пришло — таймер форсирует завершение, предотвращая "зависание".Release notes
Исправления