Skip to content

Conversation

EmandM
Copy link
Collaborator

@EmandM EmandM commented Sep 9, 2025

Purpose of this PR

A post on the discussions board pointed out that we don't have any information around the ConnectionApprovalCallback indicating that it won't work with distributed authority.

This PR:

  • Adds a note on the connection approval docs page to indicate that it doesn't work with DA
  • Updates the NetworkManager docs page to be up-to-date with DA
  • Adds a developer log level warning on ConnectionApproval when using DA that the ConnectionApproval setting is not valid (might not be the best location, maybe better in StartClient?)
  • Updates the NetworkTransformOwnershipTests to be DA friendly (needed for manual testing of this feature)

Jira ticket

n/a

Changelog

  • Added: A warning when NetworkManager.NetworkConfig.ConnectionApproval is set in a DA context.

Documentation

  • Includes edits to existing public API documentation.

Testing & QA (How your changes can be verified during release Playtest)

Mostly a docs update, no manual testing is needed.

Functional Testing

Manual testing :

  • Manual testing done

Automated tests:

  • Covered by existing automated tests
  • Covered by new automated tests

Does the change require QA team to:

  • Review automated tests?
  • Execute manual tests?
  • Provide feedback about the PR?

If any boxes above are checked the QA team will be automatically added as a PR reviewer.

Backports

Only a DA issue so 2.x only.

Docs screenshots

Connection Approval:

Screenshot 2025-09-09 at 11 37 58 AM

NetworkConfig settings

Screenshot 2025-09-09 at 11 37 48 AM

NetworkManager start

Screenshot 2025-09-09 at 11 37 36 AM

@EmandM EmandM requested review from jabbacakes and a team as code owners September 9, 2025 15:44
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks real nice Emma!

👍

@EmandM EmandM merged commit e8f8981 into develop-2.0.0 Sep 10, 2025
26 checks passed
@EmandM EmandM deleted the chore/add-da-connection-approval-warnings branch September 10, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants