Fix mail tags in mailer responder for thp 4.0 #949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 4.0 tags is automatically sometag="tag" Old mailer.py would not work with for an example office365 since popped value would be \"some@mail.com\" litteral which would cause 5.2.0 STOREDRV.Submission.Exception:InvalidRecipientsException; Failed to process message due to a permanent exception with message Recipient 'some@mail.com' is not resolved. All recipients must be resolved before a message can be submitted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
besides a problem where it would look for tags starting with "mail:" which is not possible in thehive 4.0 all tags must start with tag=.
there is also a problem where it take the literal quotes escaped inside the tag and submits it to the mail server, this causes an error on office365 with:
5.2.0 STOREDRV.Submission.Exception:InvalidRecipientsException; Failed to process message due to a permanent exception with message Recipient 'some@mail.com' is not resolved. All recipients must be resolved before a message can be submitted.