-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
feat: add count distinct primes from binary string algorithm #2970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 5 commits
55d5f0d
628174d
05f1a9c
789a92c
25a5d73
1213f92
6247d96
2c97141
3e3e75c
9be8bb3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,85 @@ | ||||||||
/** | ||||||||
* @file count_distinct_primes_from_binary_string.cpp | ||||||||
* @brief Count distinct primes formed from binary strings using allowed operations. | ||||||||
* | ||||||||
* @author Rudraksh Tank | ||||||||
* @date July 2025 | ||||||||
* | ||||||||
* @details | ||||||||
* Given a binary string, the task is to count how many distinct prime decimal numbers | ||||||||
* can be formed by: | ||||||||
* - Swapping any two characters (makes position irrelevant) | ||||||||
* - Changing any '1' to '0' (not the reverse) | ||||||||
* | ||||||||
* Efficient solution using bit manipulation and Sieve of Eratosthenes. | ||||||||
* | ||||||||
* Tags: Bit Manipulation, Prime Numbers, Combinatorics, Greedy, Bitmask | ||||||||
*/ | ||||||||
|
||||||||
#include <bit> | ||||||||
#include <iostream> | ||||||||
#include <vector> | ||||||||
#include <unordered_set> | ||||||||
#include <algorithm> | ||||||||
|
||||||||
const int MAX = 1e6; | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. max cannot be a negative number, hence replace int with uint32_t There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you still havent done this
Suggested change
|
||||||||
static std::vector<bool> is_prime; | ||||||||
|
||||||||
rudrakshtank marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||
/** | ||||||||
* @namespace bit_manipulation | ||||||||
* @brief Bit manipulation algorithms | ||||||||
*/ | ||||||||
namespace bit_manipulation { | ||||||||
|
||||||||
void precomputePrimes() { | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Again would recommend using constexpr to do the computation at compile time |
||||||||
is_prime.assign(MAX + 1, true); | ||||||||
is_prime[0] = is_prime[1] = false; | ||||||||
for (int i = 2; i * i <= MAX; i++) { | ||||||||
if (is_prime[i]) { | ||||||||
for (int j = i * i; j <= MAX; j += i) { | ||||||||
is_prime[j] = false; | ||||||||
} | ||||||||
} | ||||||||
} | ||||||||
} | ||||||||
|
||||||||
/** | ||||||||
* @brief Counts distinct prime numbers that can be formed from the given binary string. | ||||||||
* @param s Binary string input | ||||||||
* @return Number of distinct primes possible after allowed transformations | ||||||||
*/ | ||||||||
int countPrimeBinaryStrings(const std::string &s) { | ||||||||
int n = s.length(); | ||||||||
int k = std::count(s.begin(), s.end(), '1'); | ||||||||
int cnt = 0; | ||||||||
int limit = 1 << n; | ||||||||
|
||||||||
std::unordered_set<int> seen; | ||||||||
|
||||||||
for (int i = 2; i < limit; i++) { | ||||||||
if (std::popcount(i) <= k && is_prime[i]) { | ||||||||
if (!seen.count(i)) { | ||||||||
cnt++; | ||||||||
seen.insert(i); | ||||||||
} | ||||||||
} | ||||||||
} | ||||||||
|
||||||||
return cnt; | ||||||||
} | ||||||||
|
||||||||
void tests(){ | ||||||||
precomputePrimes(); | ||||||||
std::string s; | ||||||||
std::cin >> s; | ||||||||
std::cout << countPrimeBinaryStrings(s) << std::endl; | ||||||||
} | ||||||||
|
||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. tests should be outside the namespace and static, A test should be comparing a computed value to a known value using an assert statement |
||||||||
} //bit manipulation | ||||||||
/** | ||||||||
realstealthninja marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||
* @brief Main function to test the algorithm. | ||||||||
*/ | ||||||||
int main() { | ||||||||
tests(); | ||||||||
return 0; | ||||||||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add documentation for all the above headers as shown in the example