Skip to content

Conversation

Isira-Seneviratne
Copy link
Member

What is it?

  • Codebase improvement (dev facing)

Description of the changes in your PR

  • Format several plural messages such as the watching, view counts using the Core i18n library's MessageFormat. For more information, see here.
  • Rename some methods and perform some refactors, including removing an unused class.

Before/After Screenshots/Screen Record

  • Before:
  • After:

Fixes the following issue(s)

  • Fixes #

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

# Conflicts:
#	app/src/main/res/values-ar-rLY/strings.xml
#	app/src/main/res/values-ar/strings.xml
#	app/src/main/res/values-be/strings.xml
#	app/src/main/res/values-ber/strings.xml
#	app/src/main/res/values-bg/strings.xml
#	app/src/main/res/values-bn/strings.xml
#	app/src/main/res/values-ckb/strings.xml
#	app/src/main/res/values-cs/strings.xml
#	app/src/main/res/values-da/strings.xml
#	app/src/main/res/values-el/strings.xml
#	app/src/main/res/values-eo/strings.xml
#	app/src/main/res/values-et/strings.xml
#	app/src/main/res/values-fa/strings.xml
#	app/src/main/res/values-fi/strings.xml
#	app/src/main/res/values-gl/strings.xml
#	app/src/main/res/values-he/strings.xml
#	app/src/main/res/values-hi/strings.xml
#	app/src/main/res/values-hu/strings.xml
#	app/src/main/res/values-is/strings.xml
#	app/src/main/res/values-ko/strings.xml
#	app/src/main/res/values-ku/strings.xml
#	app/src/main/res/values-lt/strings.xml
#	app/src/main/res/values-mk/strings.xml
#	app/src/main/res/values-ms/strings.xml
#	app/src/main/res/values-ne/strings.xml
#	app/src/main/res/values-nl-rBE/strings.xml
#	app/src/main/res/values-or/strings.xml
#	app/src/main/res/values-pa/strings.xml
#	app/src/main/res/values-sat/strings.xml
#	app/src/main/res/values-sv/strings.xml
#	app/src/main/res/values-te/strings.xml
#	app/src/main/res/values-th/strings.xml
#	app/src/main/res/values-ur/strings.xml
#	app/src/main/res/values-zh-rCN/strings.xml
@github-actions github-actions bot added the size/giant PRs with more than 750 changed lines label Aug 1, 2025
@Isira-Seneviratne Isira-Seneviratne added localisation / translation Everything that has to do with translations or Weblate codequality Improvements to the codebase to improve the code quality labels Aug 1, 2025
# Conflicts:
#	app/src/main/res/values-da/strings.xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codequality Improvements to the codebase to improve the code quality localisation / translation Everything that has to do with translations or Weblate size/giant PRs with more than 750 changed lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant