Keep Main Fragment until user's input when searching in settings #12345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep Main Fragment until user's input
Stypox
reviewed
Jun 10, 2025
There was a problem hiding this comment.
Thanks! I think we can keep things simpler though, and just make the "No results" page non clickable. Once you press on "search" it makes sense to open the search menu fully I believe, instead of continuing to show the list of main categories. What do others think? @Profpatsch @ShareASmile
There was a problem hiding this comment.
Changes in this class should be reverted as they are caused by different indentation settings in the IDE
Comment on lines
+440
to
+452
| // Functions needed for testing | ||
| protected EditText getSearchEditText() { | ||
| return searchEditText; | ||
| } | ||
|
|
||
| public void setMockEditText(final EditText editText) { | ||
| this.searchEditText = editText; | ||
| } | ||
|
|
||
| protected static int getFragmentHolderId() { | ||
| return FRAGMENT_HOLDER_ID; | ||
| } | ||
|
|
ShareASmile
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display fragment based on search text
What is it?
Description of the changes in your PR
Create function showMainSettingsFragment() to display main fragment without adding it to a stack
Dynamically switches between PreferenceSearchFragment and MainSettingsFragment depending on the input text.
Disposes of searchDisposable safely in onDestroy() to avoid memory leaks.
runtime.
Before/After Screenshots/Screen Record
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence