test(react-query/HydrationBoundary): add tests for 'non-object' state and missing 'queries' property handling #9605
+48
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and missing 'queries' property handling
WalkthroughAdds two tests to HydrationBoundary.test.tsx to ensure no hydration occurs when provided state is non-object or lacks a queries property, using a mocked hydrate call and timer advancement within a QueryClientProvider setup. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
|
View your CI Pipeline Execution ↗ for commit 1fe93b6
☁️ Nx Cloud last updated this comment at |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/react-query/src/__tests__/HydrationBoundary.test.tsx (1)
365-387: Minor cleanups for clarity and resilience
- Prefer
expect(hydrateSpy).not.toHaveBeenCalled()overtoHaveBeenCalledTimes(0).vi.advanceTimersByTimeAsync(0)isn’t needed; hydration would be synchronous if it happened.- Use try/finally to always restore the spy and clear the client even if an assertion fails.
- Optional: rename the second test to be more explicit, e.g., “should not hydrate queries if state.queries is missing”.
Apply diffs:
@@ - test('should not hydrate queries if state is not an object', async () => { + test('should not hydrate queries if state is not an object', async () => { const queryClient = new QueryClient() const hydrateSpy = vi.spyOn(coreModule, 'hydrate') - function Page() { - return null - } - - render( - <QueryClientProvider client={queryClient}> - <HydrationBoundary state={'invalid-state' as any}> - <Page /> - </HydrationBoundary> - </QueryClientProvider>, - ) - - await vi.advanceTimersByTimeAsync(0) - expect(hydrateSpy).toHaveBeenCalledTimes(0) - - hydrateSpy.mockRestore() - queryClient.clear() + try { + function Page() { + return null + } + render( + <QueryClientProvider client={queryClient}> + <HydrationBoundary state={'invalid-state' as any}> + <Page /> + </HydrationBoundary> + </QueryClientProvider>, + ) + expect(hydrateSpy).not.toHaveBeenCalled() + } finally { + hydrateSpy.mockRestore() + queryClient.clear() + } }) @@ - test('should handle state without queries property gracefully', async () => { + test('should not hydrate queries if state.queries is missing', async () => { const queryClient = new QueryClient() const hydrateSpy = vi.spyOn(coreModule, 'hydrate') - function Page() { - return null - } - - render( - <QueryClientProvider client={queryClient}> - <HydrationBoundary state={{} as any}> - <Page /> - </HydrationBoundary> - </QueryClientProvider>, - ) - - await vi.advanceTimersByTimeAsync(0) - expect(hydrateSpy).toHaveBeenCalledTimes(0) - - hydrateSpy.mockRestore() - queryClient.clear() + try { + function Page() { + return null + } + render( + <QueryClientProvider client={queryClient}> + <HydrationBoundary state={{} as any}> + <Page /> + </HydrationBoundary> + </QueryClientProvider>, + ) + expect(hydrateSpy).not.toHaveBeenCalled() + } finally { + hydrateSpy.mockRestore() + queryClient.clear() + } })Also applies to: 389-411
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
packages/react-query/src/__tests__/HydrationBoundary.test.tsx(1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
packages/react-query/src/__tests__/HydrationBoundary.test.tsx (1)
packages/react-query/src/HydrationBoundary.tsx (1)
HydrationBoundary(25-108)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: autofix
- GitHub Check: Preview
- GitHub Check: Test
🔇 Additional comments (2)
packages/react-query/src/__tests__/HydrationBoundary.test.tsx (2)
365-387: LGTM: Correctly asserts no hydration for non-object stateThis matches HydrationBoundary’s guard (typeof state !== 'object' → early return), so hydrate should never be called.
389-411: LGTM: Covers missingqueriesproperty pathState fallback to
queries || []means no hydration; this test validates that path.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9605 +/- ##
===========================================
+ Coverage 45.21% 84.51% +39.29%
===========================================
Files 208 26 -182
Lines 8335 368 -7967
Branches 1889 108 -1781
===========================================
- Hits 3769 311 -3458
+ Misses 4119 48 -4071
+ Partials 447 9 -438 🚀 New features to boost your workflow:
|
manudeli
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AS-IS
TO-BE
Summary by CodeRabbit