Skip to content

fix(query-core): ensure combine re-executes after cache restoration with memoized combine #9592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Sep 2, 2025
+292 −20

test(react-query): add test for stable combine optimization on unrela…

44bfedb
Select commit
Loading
Failed to load commit list.
Merged

fix(query-core): ensure combine re-executes after cache restoration with memoized combine #9592

test(react-query): add test for stable combine optimization on unrela…
44bfedb
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 2, 2025 in 0s

59.35% (+14.12%) compared to 5221029

View this Pull Request on Codecov

59.35% (+14.12%) compared to 5221029

Details

Codecov Report

❌ Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.35%. Comparing base (5221029) to head (44bfedb).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #9592       +/-   ##
===========================================
+ Coverage   45.23%   59.35%   +14.12%     
===========================================
  Files         208      137       -71     
  Lines        8335     5578     -2757     
  Branches     1882     1510      -372     
===========================================
- Hits         3770     3311      -459     
+ Misses       4118     1963     -2155     
+ Partials      447      304      -143
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 87.00% <ø> (ø)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister 43.85% <ø> (ø)
@tanstack/query-broadcast-client-experimental 24.39% <ø> (ø)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core 97.42% <87.50%> (+<0.01%) ⬆️
@tanstack/query-devtools 3.48% <ø> (ø)
@tanstack/query-persist-client-core 79.47% <ø> (ø)
@tanstack/query-sync-storage-persister 84.61% <ø> (ø)
@tanstack/query-test-utils ∅ <ø> (∅)
@tanstack/react-query 96.00% <ø> (ø)
@tanstack/react-query-devtools 10.00% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query 78.13% <ø> (ø)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client 100.00% <ø> (ø)
@tanstack/svelte-query 87.58% <ø> (ø)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (ø)
@tanstack/vue-query 71.10% <ø> (ø)
@tanstack/vue-query-devtools ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov