Skip to content

[BugFix] Clear mv's version map if restore job failed #62634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2025
Merged

[BugFix] Clear mv's version map if restore job failed #62634

merged 1 commit into from
Sep 2, 2025

Conversation

LiShuMing
Copy link
Contributor

@LiShuMing LiShuMing commented Sep 2, 2025 •
edited
Loading

Why I'm doing:

This is a bug introduced by #62514

  • Clear mv's version map if restore job failed, otherwise following mv refresh may be skipped which will cause the mv result is empty.

What I'm doing:

Fixes https://github.com/StarRocks/StarRocksTest/issues/10191

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 4.0
    • 3.5
    • 3.4
    • 3.3

@LiShuMing
Clear mv's version map if restore job failed
8aea718 
Signed-off-by: shuming.li <ming.moriarty@gmail.com>
@LiShuMing LiShuMing requested a review from a team as a code owner September 2, 2025 05:44
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Sep 2, 2025

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@LiShuMing LiShuMing enabled auto-merge (squash) September 2, 2025 08:26
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 2, 2025

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 2, 2025

[FE Incremental Coverage Report]

❌ fail : 0 / 1 (00.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/backup/RestoreJob.java 0 1 00.00% [1686]

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 2, 2025

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@kangkaisen kangkaisen disabled auto-merge September 2, 2025 08:59
@kangkaisen kangkaisen merged commit 8325d26 into StarRocks:main Sep 2, 2025
90 of 98 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 2, 2025

@Mergifyio backport branch-3.5

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 2, 2025

@Mergifyio backport branch-3.4

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 2, 2025

@Mergifyio backport branch-4.0

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 2, 2025

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Sep 2, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 2, 2025 •
edited
Loading

backport branch-3.5

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 2, 2025 •
edited
Loading

backport branch-3.4

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 2, 2025 •
edited
Loading

backport branch-4.0

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 2, 2025 •
edited
Loading

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 2, 2025
@LiShuMing @mergify
[BugFix] Clear mv's version map if restore job failed (#62634)
ce28c5e 
Signed-off-by: shuming.li <ming.moriarty@gmail.com>
(cherry picked from commit 8325d26)
@mergify mergify bot mentioned this pull request Sep 2, 2025
Merged
23 tasks
mergify bot pushed a commit that referenced this pull request Sep 2, 2025
@LiShuMing @mergify
[BugFix] Clear mv's version map if restore job failed (#62634)
9298881 
Signed-off-by: shuming.li <ming.moriarty@gmail.com>
(cherry picked from commit 8325d26)
mergify bot pushed a commit that referenced this pull request Sep 2, 2025
@LiShuMing @mergify
[BugFix] Clear mv's version map if restore job failed (#62634)
aa05585 
Signed-off-by: shuming.li <ming.moriarty@gmail.com>
(cherry picked from commit 8325d26)
This was referenced Sep 2, 2025
Merged
Merged
mergify bot pushed a commit that referenced this pull request Sep 2, 2025
@LiShuMing @mergify
[BugFix] Clear mv's version map if restore job failed (#62634)
b400072 
Signed-off-by: shuming.li <ming.moriarty@gmail.com>
(cherry picked from commit 8325d26)
@mergify mergify bot mentioned this pull request Sep 2, 2025
Merged
23 tasks
wanpengfei-git pushed a commit that referenced this pull request Sep 2, 2025
@mergify @LiShuMing
[BugFix] Clear mv's version map if restore job failed (backport #62634)…
995d35c 
… (#62645)

Signed-off-by: shuming.li <ming.moriarty@gmail.com>
Co-authored-by: shuming.li <ming.moriarty@gmail.com>
wanpengfei-git pushed a commit that referenced this pull request Sep 2, 2025
@mergify @LiShuMing
[BugFix] Clear mv's version map if restore job failed (backport #62634)…
3c9d5cb 
… (#62644)

Signed-off-by: shuming.li <ming.moriarty@gmail.com>
Co-authored-by: shuming.li <ming.moriarty@gmail.com>
wanpengfei-git pushed a commit that referenced this pull request Sep 2, 2025
@mergify @LiShuMing
[BugFix] Clear mv's version map if restore job failed (backport #62634)…
e8e3527 
… (#62643)

Signed-off-by: shuming.li <ming.moriarty@gmail.com>
Co-authored-by: shuming.li <ming.moriarty@gmail.com>
wanpengfei-git pushed a commit that referenced this pull request Sep 2, 2025
@mergify @LiShuMing
[BugFix] Clear mv's version map if restore job failed (backport #62634)…
f0b2368 
… (#62642)

Signed-off-by: shuming.li <ming.moriarty@gmail.com>
Co-authored-by: shuming.li <ming.moriarty@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satanson satanson satanson approved these changes

@kangkaisen kangkaisen kangkaisen approved these changes

Assignees

@LiShuMing LiShuMing

Labels
3.3-merged 3.4-merged 3.5-merged 4.0-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LiShuMing @satanson @kangkaisen