Skip to content

Conversation

LiShuMing
Copy link
Contributor

@LiShuMing LiShuMing commented Sep 2, 2025

Why I'm doing:

refresh mv with force is expected to refresh target partitions no matter what happens, but there are some situations that nothing is done in current implementation(eg: mv's partition data corruptions)

In those cases, what users can do is only to drop the mv and recreate it again.

What I'm doing:

To ensure mv force refresh will refresh target partitions:

  • drop target partitions first
  • mark target partitions as to-refresh partitions.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 4.0
    • 3.5
    • 3.4
    • 3.3

Signed-off-by: shuming.li <ming.moriarty@gmail.com>
Signed-off-by: shuming.li <ming.moriarty@gmail.com>
Signed-off-by: shuming.li <ming.moriarty@gmail.com>
Signed-off-by: shuming.li <ming.moriarty@gmail.com>
@LiShuMing LiShuMing changed the title [Enhancement] Ensure mv force refresh will refresh mv target partitions [Enhancement] Ensure mv force refresh will refresh target partitions forcely Sep 2, 2025
@LiShuMing LiShuMing changed the title [Enhancement] Ensure mv force refresh will refresh target partitions forcely [Enhancement] Ensure mv force refresh will refresh target partitions Sep 2, 2025
Signed-off-by: shuming.li <ming.moriarty@gmail.com>
@LiShuMing LiShuMing requested a review from a team as a code owner September 2, 2025 11:38
Copy link

sonarqubecloud bot commented Sep 2, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copy link

github-actions bot commented Sep 2, 2025

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Sep 2, 2025

[FE Incremental Coverage Report]

pass : 62 / 64 (96.88%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/scheduler/mv/MVPCTRefreshNonPartitioner.java 0 1 00.00% [46]
🔵 com/starrocks/scheduler/mv/MVPCTRefreshRangePartitioner.java 22 23 95.65% [105]
🔵 com/starrocks/scheduler/TaskManager.java 1 1 100.00% []
🔵 com/starrocks/common/util/DynamicPartitionUtil.java 2 2 100.00% []
🔵 com/starrocks/sql/common/PCellSortedSet.java 1 1 100.00% []
🔵 com/starrocks/scheduler/MVTaskRunProcessor.java 2 2 100.00% []
🔵 com/starrocks/scheduler/BaseTaskRunProcessor.java 1 1 100.00% []
🔵 com/starrocks/scheduler/mv/MVPCTRefreshPartitioner.java 7 7 100.00% []
🔵 com/starrocks/scheduler/mv/MVPCTRefreshListPartitioner.java 13 13 100.00% []
🔵 com/starrocks/scheduler/mv/BaseMVRefreshProcessor.java 8 8 100.00% []
🔵 com/starrocks/scheduler/TaskRunContext.java 4 4 100.00% []
🔵 com/starrocks/scheduler/TaskRun.java 1 1 100.00% []

Copy link

github-actions bot commented Sep 2, 2025

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant