Skip to content

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 2, 2025

Why I'm doing:

What I'm doing:

in this pr, I support expression reuse strategy on outer join's where predicates, just like what we do in scan predicates(#52889).

currently, this optimization applies to hash/nest loop outer joins.
For inner joins, both where and on predicates appear in the PhysicalJoinOperator's onPredicate , rather than predicates . I'm concerned that splitting the onPredicate clause might introduce additional risks, so I didn't do it in this pr, we can support this in the future if needed.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 4.0
    • 3.5
    • 3.4
    • 3.3

This is an automatic backport of pull request #62139 done by [Mergify](https://mergify.com).

Signed-off-by: silverbullet233 <3675229+silverbullet233@users.noreply.github.com>
(cherry picked from commit 6c220d0)
Copy link
Contributor Author

mergify bot commented Sep 2, 2025

🧪 CI Insights

Here's what we observed from your CI run for dfd25c2.

🟢 All jobs passed!

But CI Insights is watching 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant